Fan out config option types, update variable type #32
+93
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pearce-Ropion
previously approved these changes
Jan 28, 2026
Collaborator
Pearce-Ropion
left a comment
Pearce-Ropion
left a comment
There was a problem hiding this comment.
Should any of this be added to the README?
Contributor
Author
I believe not. |
peternandersson
force-pushed
the
peter/fan-out-config-option-types
branch
from
7ac9067 to
495807f
Compare
ryan-sigma
approved these changes
Jan 29, 2026
Contributor
ryan-sigma
left a comment
ryan-sigma
left a comment
There was a problem hiding this comment.
Generally LGTM, AI review did well and I spot checked a few things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, we didn't have a
valuefield in theWorkbookControltype, even though it exists in the object we return.Also fans out config option types & adds a base type for them to inherit from.
No functional changes.